Remove trace logger in entitlements transformer on default path #136152
+1
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t need to be transformed. This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender. Fixes elastic#132280
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove trace logger in
Transformeron the default path when a class doesn't need to be transformed.This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.
Fixes #132280